[Selective Hydration] Increase priority for non-synchronous discrete events and retries #16935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: 3694a3b...3381578 react-dom
react-reconciler
|
acdlite
approved these changes
Sep 28, 2019
| await promise; | ||
|
|
||
| // After the click, we should prioritize D and the Click first, | ||
| // and only after that render A and C. |
There was a problem hiding this comment.
I think you copy-pasted this comment but forgot to update it
sebmarkbage
force-pushed
the
selectivehydration
branch
from
96ee8ba
to
3381578
Compare
|
I wonder, would this have future affects on Flare? It doesn't matter right now, but if you think it does a test that is skipped for Flare would be useful. |
|
The way I'm thinking about it is that we're testing the interaction between event system <-> replaying system in PartialHydration file which has tests for both. In this, SelectiveHydration, file we're testing the interaction between event replaying <-> reconciler priorities. We're actually testing the reconciler here, more than the events themselves. So we don't need to duplicate every combination of these tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an increased priority dehydrated boundary commits as dehydrated because it is suspended, it no longer has any
expirationTimescheduled. So when the thenable resolves, it gets the default priority. This increases theretryTime. This will almost immediately expire and effectively become sync. We might want to make this slightly higher than Normal but longer expiration time.The upside of eagerly computing this (as opposed to when resolved) is that we can guarantee a predictable order of priorities. (First event in, highest pri.)
This PR also ensures that we increase the priority of subsequent events after the first can't be done synchronously. There's no reason to keep them as high as sync since at that point it is already too late since replaying has kicked in. So we schedule with user blocking pri for this case.